ajantha-bhat commented on a change in pull request #3584: [CARBONDATA-3718]
Support SegmentLevel MinMax for better Pruning and less driver memory usage for
cache
URL: https://github.com/apache/carbondata/pull/3584#discussion_r396223698
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
##########
@@ -140,9 +152,28 @@ public DataMapBuilder createBuilder(Segment segment,
String shardName,
segmentMap.put(segment.getSegmentNo(), segment);
Set<TableBlockIndexUniqueIdentifier> identifiers =
getTableBlockIndexUniqueIdentifiers(segment);
- // get tableBlockIndexUniqueIdentifierWrappers from segment file info
- getTableBlockUniqueIdentifierWrappers(partitionsToPrune,
- tableBlockIndexUniqueIdentifierWrappers, identifiers);
+ if (null != partitionsToPrune) {
+ // get tableBlockIndexUniqueIdentifierWrappers from segment file info
+ getTableBlockUniqueIdentifierWrappers(partitionsToPrune,
+ tableBlockIndexUniqueIdentifierWrappers, identifiers);
+ } else {
+ SegmentMetaDataInfo segmentMetaDataInfo =
segment.getSegmentMetaDataInfo();
Review comment:
If we keep SegmentFileStore inside Segment class and read the segment before
calling readCommittedScope.committedIndexFiles. we can avoid creating the
TableBlockIndexUniqueIdentifier object. May be more changes now. Can do in
other PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
