Indhumathi27 commented on a change in pull request #3661: [WIP] Support
materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r396367410
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/listeners/DropCacheEventListeners.scala
##########
@@ -31,31 +32,28 @@ import
org.apache.carbondata.core.metadata.schema.datamap.DataMapClassProvider
import org.apache.carbondata.core.metadata.schema.table.DataMapSchema
import org.apache.carbondata.events.{DropTableCacheEvent, Event,
OperationContext, OperationEventListener}
-object DropCacheDataMapEventListener extends OperationEventListener {
+object DropCacheMVEventListener extends OperationEventListener {
- val LOGGER = LogServiceFactory.getLogService(this.getClass.getCanonicalName)
+ val LOGGER: Logger =
LogServiceFactory.getLogService(this.getClass.getCanonicalName)
/**
* Called on a specified event occurrence
- *
- * @param event
- * @param operationContext
*/
override protected def onEvent(event: Event, operationContext:
OperationContext): Unit = {
event match {
case dropCacheEvent: DropTableCacheEvent =>
val carbonTable = dropCacheEvent.carbonTable
val sparkSession = dropCacheEvent.sparkSession
val internalCall = dropCacheEvent.internalCall
- if (carbonTable.isChildTableForMV && !internalCall) {
+ if (carbonTable.isMaterializedView && !internalCall) {
throw new UnsupportedOperationException("Operation not allowed on
child table.")
}
if (carbonTable.hasMVCreated) {
val childrenSchemas = DataMapStoreManager.getInstance
.getDataMapSchemasOfTable(carbonTable).asScala
.filter(dataMapSchema => null !=
dataMapSchema.getRelationIdentifier &&
- !dataMapSchema.isIndexDataMap)
+ !dataMapSchema.isIndex)
Review comment:
Remove this if check code added for mv, as drop cache handled in
DropCacheCommand
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
