Indhumathi27 commented on a change in pull request #3661: [WIP] Support
materialized view
URL: https://github.com/apache/carbondata/pull/3661#discussion_r396366706
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/hive/CarbonAnalysisRules.scala
##########
@@ -207,16 +219,26 @@ case class CarbonIUDAnalysisRule(sparkSession:
SparkSession) extends Rule[Logica
val projList = Seq(UnresolvedAlias(UnresolvedStar(alias.map(Seq(_)))),
tupleId)
val carbonTable =
CarbonEnv.getCarbonTable(table.tableIdentifier)(sparkSession)
if (carbonTable != null) {
- if (carbonTable.isChildTableForMV) {
+ if (carbonTable.isMaterializedView) {
throw new UnsupportedOperationException(
"Delete operation is not supported for datamap table")
}
+ val viewManager = MaterializedViewManagerInSpark.get(sparkSession)
+ val viewSchemas = viewManager.getSchemasOnTable(carbonTable)
+ if (!viewSchemas.isEmpty) {
+ viewSchemas.asScala.foreach { schema =>
+ viewManager.setStatus(
+ schema.getIdentifier,
+ MaterializedViewStatus.DISABLED
+ )
+ }
+ }
val indexSchemas =
DataMapStoreManager.getInstance().getDataMapSchemasOfTable(carbonTable)
if (carbonTable.hasMVCreated) {
val allDataMapSchemas = DataMapStoreManager.getInstance
.getDataMapSchemasOfTable(carbonTable).asScala
.filter(dataMapSchema => null !=
dataMapSchema.getRelationIdentifier &&
- !dataMapSchema.isIndexDataMap).asJava
+ !dataMapSchema.isIndex).asJava
Review comment:
remove this if check code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
