QiangCai commented on a change in pull request #3661: [CARBONDATA-3704] Support
create materialized view on all type table, and make mv support mutil-tenant.
URL: https://github.com/apache/carbondata/pull/3661#discussion_r401315843
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/IndexChooser.java
##########
@@ -269,14 +269,14 @@ private void extractColumnExpression(Expression
expression,
}
}
- private TableDataMap chooseDataMap(List<TableDataMap> allDataMap,
+ private TableIndex chooseDataMap(List<TableIndex> allDataMap,
Review comment:
better to change all DataMap to index once.
if not, code will be hard to read
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services