QiangCai commented on a change in pull request #3661: [CARBONDATA-3704] Support
create materialized view on all type table, and make mv support mutil-tenant.
URL: https://github.com/apache/carbondata/pull/3661#discussion_r401341097
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
##########
@@ -885,6 +894,16 @@ public boolean isChildTableForMV() {
.get(CarbonCommonConstants.PARENT_TABLES).isEmpty();
}
+ /**
+ * Return true if this table is a MV table (child table of other table)
+ */
+ public boolean isMaterializedView() {
+ return tableInfo.getFactTable().getTableProperties()
+ .get(CarbonCommonConstants.ASSOCIATED_TABLES) != null &&
+ !tableInfo.getFactTable().getTableProperties()
+ .get(CarbonCommonConstants.ASSOCIATED_TABLES).isEmpty();
Review comment:
please remove redundancy code.
how about use MV_ON_TABLES OR MV_RELATED_TABLES instead of
ASSOCIATED_TABLES ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
