ajantha-bhat commented on a change in pull request #3688: [CARBONDATA-3765]
Refactor Index Metadata for CG and FG Indexes
URL: https://github.com/apache/carbondata/pull/3688#discussion_r405975524
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/dev/IndexFactory.java
##########
@@ -187,7 +187,8 @@ public void deleteSegmentIndexData(String segmentNo)
throws IOException {
* 4. INDEX_COLUMNS should be exists in table columns
*/
public void validate() throws MalformedIndexCommandException {
- List<CarbonColumn> indexColumns =
carbonTable.getIndexedColumns(dataMapSchema);
+ List<CarbonColumn> indexColumns =
+ carbonTable.getIndexedColumns(dataMapSchema.getIndexColumns());
Review comment:
datamap schema should have already validated columns. If columns are
dropped, we can update the datamap schema. Everytime checking columns in
datamap schema is valid or not from all the flows is not efficient
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
