ajantha-bhat commented on a change in pull request #3688: [CARBONDATA-3765]
Refactor Index Metadata for CG and FG Indexes
URL: https://github.com/apache/carbondata/pull/3688#discussion_r405998756
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/index/CarbonRefreshIndexCommand.scala
##########
@@ -71,30 +80,81 @@ case class CarbonRefreshIndexCommand(
private def refreshIndex(
sparkSession: SparkSession,
parentTable: CarbonTable,
- indexOp: Optional[DataMapSchema]): Unit = {
- val schema = indexOp.get
+ indexMetaData: IndexMetadata): Unit = {
+ var indexInfo: util.Map[String, String] = new util.HashMap[String,
String]()
+ val allIndexesIterator = indexMetaData.getIndexesMap.entrySet().iterator()
+ breakable {
+ while (allIndexesIterator.hasNext) {
+ val currentIndex = allIndexesIterator.next()
+ if
(!currentIndex.getKey.equalsIgnoreCase(CarbonIndexProvider.SI.getIndexProviderName))
{
Review comment:
If we are excluding SI everywhere, It is better to have separate map for
each provider in `IndexMetadata`. access only Non SI maps.
or you can directly lookup non SI providers
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
