VenuReddy2103 commented on a change in pull request #3772:
URL: https://github.com/apache/carbondata/pull/3772#discussion_r440386464
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java
##########
@@ -188,6 +189,14 @@ private static FilterExecuter createFilterExecuterTree(
return new FalseFilterExecutor();
case ROWLEVEL:
default:
+ if (filterExpressionResolverTree.getFilterExpression() instanceof
UnknownExpression) {
Review comment:
In the initial version of the feature PR, polygon expression and
executor type were defined explitily for polygon filter in carbondata-core
module itself. But Ravi's review comment suggested the use of
`UnknownExpression`(similar to `SparkUnknownExpression`) and have
carbondata-geo depends on carbondata-core. But not the other way round.
Currently `UnknownExpression` always uses `RowLevelFilterExecuterImpl` and
applies filter for each row without pruning(i.e., no block, blocklet and page
pruning). So have enhanced the `UnknownExpression` with pruning ability.
##########
File path:
geo/src/main/java/org/apache/carbondata/geo/scan/expression/PolygonExpression.java
##########
@@ -46,15 +51,16 @@
private CustomIndex<List<Long[]>> instance;
private List<Long[]> ranges = new ArrayList<Long[]>();
private ColumnExpression column;
- private ExpressionResult trueExpRes;
- private ExpressionResult falseExpRes;
+ private static final ExpressionResult trueExpRes =
Review comment:
Have replied for it the immediate below comment. Please let me know if
you have any other opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
