VenuReddy2103 commented on a change in pull request #3772:
URL: https://github.com/apache/carbondata/pull/3772#discussion_r445481119



##########
File path: 
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java
##########
@@ -188,6 +189,14 @@ private static FilterExecuter createFilterExecuterTree(
           return new FalseFilterExecutor();
         case ROWLEVEL:
         default:
+          if (filterExpressionResolverTree.getFilterExpression() instanceof 
UnknownExpression) {
+            FilterExecuter filterExecuter =
+                ((UnknownExpression) 
filterExpressionResolverTree.getFilterExpression())
+                    .getFilterExecuter(filterExpressionResolverTree, 
segmentProperties);
+            if (filterExecuter != null) {

Review comment:
       I understand what you meant. I think, it is better to create the 
RowLevelFilterExecuterImpl only at this place. If UnknownExpression do not have 
any specific implemenation, it will be like a fallback to 
RowLevelFilterExecuterImpl.
    Also, if we have return RowLevelFilterExecuterImpl from 
UnknownExpression.getFilterExecuter, we need to pass complexDimensionInfoMap 
and all overiding methods will have this argument. It is an unused argument as 
current UnKnown expressions do not support complex dimensions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to