ajantha-bhat commented on a change in pull request #3887:
URL: https://github.com/apache/carbondata/pull/3887#discussion_r476625159
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/CarbonColumnVector.java
##########
@@ -114,4 +115,20 @@
void setLazyPage(LazyPageLoader lazyPage);
+ // Add default implementation for interface,
+ // to avoid implementing presto required functions for spark or core module.
+ default List<CarbonColumnVector> getChildrenVector() {
+ return null;
Review comment:
done
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/result/vector/impl/CarbonColumnVectorImpl.java
##########
@@ -70,10 +73,14 @@
private CarbonColumnVector dictionaryVector;
+ private List<CarbonColumnVector> childrenVector;
+
private LazyPageLoader lazyPage;
private boolean loaded;
+ private ArrayList<Integer> childElementsForEachRow = null;
Review comment:
yeah. done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
