ajantha-bhat commented on a change in pull request #3887:
URL: https://github.com/apache/carbondata/pull/3887#discussion_r476636246
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveDeltaFloatingCodec.java
##########
@@ -282,6 +288,12 @@ public void decodeAndFillVector(byte[] pageData,
ColumnVectorInfo vectorInfo, Bi
for (int i = 0; i < size; i += DataTypes.INT.getSizeInBytes()) {
vector.putFloat(rowId++, (max -
ByteUtil.toIntLittleEndian(pageData, i)) / floatFactor);
}
+ } else if (pageDataType == DataTypes.LONG) {
Review comment:
I have tested, With current UT itself it is hitting. for [Null, 5.512]
it is using long as storage for complex primitive adaptive. Base behavior needs
to check. I guess it can be analyzed separately
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
