kumarvishal09 commented on a change in pull request #3887:
URL: https://github.com/apache/carbondata/pull/3887#discussion_r477308991
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
##########
@@ -376,6 +456,56 @@ private void fillVector(byte[] pageData,
CarbonColumnVector vector, DataType vec
DecimalConverterFactory.DecimalConverter decimalConverter =
vectorInfo.decimalConverter;
decimalConverter.fillVector(pageData, pageSize, vectorInfo,
nullBits, pageDataType);
}
+ } else if (pageDataType == DataTypes.BYTE_ARRAY) {
+ if (vectorDataType == DataTypes.STRING || vectorDataType ==
DataTypes.BINARY
+ || vectorDataType == DataTypes.VARCHAR) {
+ // for complex primitive string, binary, varchar type
+ int offset = 0;
+ for (int i = 0; i < pageSize; i++) {
+ byte[] stringLen = new byte[DataTypes.INT.getSizeInBytes()];
Review comment:
this byte array is not required, wrap page data inside byte buffer and
updates the position to get the length of the data
By this we can avoid creating multiple bytebuffer and byte array . Pls
handle all the places
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
