VenuReddy2103 commented on a change in pull request #3819:
URL: https://github.com/apache/carbondata/pull/3819#discussion_r472407770
##########
File path:
sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
##########
@@ -594,6 +607,446 @@ public CarbonWriterBuilder withJsonInput(Schema
carbonSchema) {
return this;
}
+ private void validateCsvFiles() throws IOException {
+ CarbonFile[] dataFiles =
this.extractDataFiles(CarbonCommonConstants.CSV_FILE_EXTENSION);
+ if (CollectionUtils.isEmpty(Arrays.asList(dataFiles))) {
+ throw new RuntimeException("CSV files can't be empty.");
+ }
+ for (CarbonFile dataFile : dataFiles) {
+ try {
+ CsvParser csvParser = SDKUtil.buildCsvParser(this.hadoopConf);
+
csvParser.beginParsing(FileFactory.getDataInputStream(dataFile.getPath(),
+ -1, this.hadoopConf));
+ } catch (IllegalArgumentException ex) {
+ if (ex.getCause() instanceof FileNotFoundException) {
+ throw new FileNotFoundException("File " + dataFile +
+ " not found to build carbon writer.");
+ }
+ throw ex;
+ }
+ }
+ this.dataFiles = dataFiles;
+ }
+
+ /**
+ * to build a {@link CarbonWriter}, which accepts loading CSV files.
+ *
+ * @param filePath absolute path under which files should be loaded.
+ * @return CarbonWriterBuilder
+ */
+ public CarbonWriterBuilder withCsvPath(String filePath) throws IOException {
+ this.validateFilePath(filePath);
+ this.filePath = filePath;
+ this.setIsDirectory(filePath);
+ this.withCsvInput();
+ this.validateCsvFiles();
+ return this;
+ }
+
+ /**
+ * to build a {@link CarbonWriter}, which accepts CSV files directory and
+ * list of file which has to be loaded.
+ *
+ * @param filePath directory where the CSV file exists.
+ * @param fileList list of files which has to be loaded.
+ * @return CarbonWriterBuilder
+ */
+ public CarbonWriterBuilder withCsvPath(String filePath, List<String>
fileList)
+ throws IOException {
+ this.fileList = fileList;
+ this.withCsvPath(filePath);
+ return this;
+ }
+
+ private void validateJsonFiles() throws IOException {
+ CarbonFile[] dataFiles =
this.extractDataFiles(CarbonCommonConstants.JSON_FILE_EXTENSION);
+ for (CarbonFile dataFile : dataFiles) {
+ try {
+ new JSONParser().parse(SDKUtil.buildJsonReader(dataFile,
this.hadoopConf));
+ } catch (FileNotFoundException ex) {
+ throw new FileNotFoundException("File " + dataFile + " not found to
build carbon writer.");
+ } catch (ParseException ex) {
+ throw new RuntimeException("File " + dataFile + " is not in json
format.");
+ }
+ }
+ this.dataFiles = dataFiles;
+ }
+
+ /**
+ * to build a {@link CarbonWriter}, which accepts loading JSON files.
+ *
+ * @param filePath absolute path under which files should be loaded.
+ * @return CarbonWriterBuilder
+ */
+ public CarbonWriterBuilder withJsonPath(String filePath) throws IOException {
+ this.validateFilePath(filePath);
+ this.filePath = filePath;
+ this.setIsDirectory(filePath);
+ this.withJsonInput();
+ this.validateJsonFiles();
+ return this;
+ }
+
+ /**
+ * to build a {@link CarbonWriter}, which accepts JSON file directory and
+ * list of file which has to be loaded.
+ *
+ * @param filePath directory where the json file exists.
+ * @param fileList list of files which has to be loaded.
+ * @return CarbonWriterBuilder
+ * @throws IOException
+ */
+ public CarbonWriterBuilder withJsonPath(String filePath, List<String>
fileList)
+ throws IOException {
+ this.fileList = fileList;
+ this.withJsonPath(filePath);
+ return this;
+ }
+
+ private void validateFilePath(String filePath) {
+ if (StringUtils.isEmpty(filePath)) {
+ throw new IllegalArgumentException("filePath can not be empty");
+ }
+ }
+
+ /**
+ * to build a {@link CarbonWriter}, which accepts loading Parquet files.
+ *
+ * @param filePath absolute path under which files should be loaded.
+ * @return CarbonWriterBuilder
+ */
+ public CarbonWriterBuilder withParquetPath(String filePath) throws
IOException {
+ this.validateFilePath(filePath);
+ this.filePath = filePath;
+ this.setIsDirectory(filePath);
+ this.writerType = WRITER_TYPE.PARQUET;
+ this.validateParquetFiles();
+ return this;
+ }
+
+ private void setIsDirectory(String filePath) {
+ if (this.hadoopConf == null) {
+ this.hadoopConf = new Configuration(FileFactory.getConfiguration());
Review comment:
Had checked the base code. In the base code, we seem to directly assign
the return value of FileFactory.getConfiguration() instead of new
Configuration. Suggest to check and keep it consistent. Check for all the
places in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
