VenuReddy2103 commented on a change in pull request #3819:
URL: https://github.com/apache/carbondata/pull/3819#discussion_r478323052
##########
File path:
sdk/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
##########
@@ -594,6 +607,446 @@ public CarbonWriterBuilder withJsonInput(Schema
carbonSchema) {
return this;
}
+ private void validateCsvFiles() throws IOException {
Review comment:
These validate methods(validate AvroFiles, ParquetFiles, CsvFiles,
JsonFiles, OrcFiles) can be in the respective type of carbon writers. Because
the way validate methods are implemented are specific to the respective format.
Validate methods get readers/parse. Very similar code is in respective writers.
Also can the validation method be called from `CarbonWriterBuilder.build()`
method based respecitve `writerType` if `dataFiles` are not null ? I think, it
can be abstract method in `CarbonWriter` to set input files to read, that is
implemented by all the writers. Writers can validate and set them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
