ajantha-bhat commented on a change in pull request #3887:
URL: https://github.com/apache/carbondata/pull/3887#discussion_r478367442
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/compress/DirectCompressCodec.java
##########
@@ -376,6 +456,56 @@ private void fillVector(byte[] pageData,
CarbonColumnVector vector, DataType vec
DecimalConverterFactory.DecimalConverter decimalConverter =
vectorInfo.decimalConverter;
decimalConverter.fillVector(pageData, pageSize, vectorInfo,
nullBits, pageDataType);
}
+ } else if (pageDataType == DataTypes.BYTE_ARRAY) {
+ if (vectorDataType == DataTypes.STRING || vectorDataType ==
DataTypes.BINARY
+ || vectorDataType == DataTypes.VARCHAR) {
+ // for complex primitive string, binary, varchar type
+ int offset = 0;
+ for (int i = 0; i < pageSize; i++) {
+ byte[] stringLen = new byte[DataTypes.INT.getSizeInBytes()];
Review comment:
done
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java
##########
@@ -98,6 +98,9 @@
*/
protected CarbonIterator queryIterator;
+ // Size of the ReusableDataBuffer based on the number of dimension
projection columns
+ protected int reusableDimensionBufferSize = 0;
Review comment:
done
##########
File path:
core/src/main/java/org/apache/carbondata/core/scan/result/BlockletScannedResult.java
##########
@@ -153,6 +154,9 @@
private ReusableDataBuffer[] measureReusableBuffer;
+ // index used by dimensionReusableBuffer
+ int dimensionReusableBufferIndex = 0;
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
