ajantha-bhat commented on a change in pull request #3887:
URL: https://github.com/apache/carbondata/pull/3887#discussion_r478856181
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/adaptive/AdaptiveCodec.java
##########
@@ -260,4 +265,65 @@ protected String debugInfo() {
return this.toString();
}
+ public static VectorUtil checkAndUpdateToChildVector(ColumnVectorInfo
vectorInfo, int pageSize,
+ CarbonColumnVector vector, DataType vectorDataType) {
+ VectorUtil vectorUtil = new VectorUtil(pageSize, vector, vectorDataType);
+ Stack<CarbonColumnVector> vectorStack = vectorInfo.getVectorStack();
+ // check and update to child vector info
+ if (vectorStack != null && vectorStack.peek() != null &&
vectorDataType.isComplexType()) {
Review comment:
**Also initialized the stack always, checking for empty now. no null
check is present**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
