ajantha-bhat commented on a change in pull request #3920:
URL: https://github.com/apache/carbondata/pull/3920#discussion_r486758917
##########
File path:
integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java
##########
@@ -78,6 +78,8 @@ private static DataType
spi2CarbondataTypeMapper(HiveColumnHandle columnHandle)
HiveType colType = columnHandle.getHiveType();
if (colType.equals(HiveType.HIVE_BOOLEAN)) {
return DataTypes.BOOLEAN;
+ } else if (colType.equals(HiveType.HIVE_BINARY)) {
Review comment:
I can see byte and float data type is also missing. can you add and test
for it ?
##########
File path:
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala
##########
@@ -230,6 +230,37 @@ class PrestoTestNonTransactionalTableFiles extends
FunSuiteLike with BeforeAndAf
}
}
+ def buildOnlyBinary(rows: Int, sortColumns: Array[String], path : String):
Any = {
Review comment:
existing binary testcase only can you add filter query ? I guess no need
to add new testcase for it, it will slow down CI running time.
##########
File path:
integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java
##########
@@ -78,6 +78,8 @@ private static DataType
spi2CarbondataTypeMapper(HiveColumnHandle columnHandle)
HiveType colType = columnHandle.getHiveType();
if (colType.equals(HiveType.HIVE_BOOLEAN)) {
return DataTypes.BOOLEAN;
+ } else if (colType.equals(HiveType.HIVE_BINARY)) {
Review comment:
I can see byte and float data type is also missing. can you add and test
for it ?
##########
File path:
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala
##########
@@ -230,6 +230,37 @@ class PrestoTestNonTransactionalTableFiles extends
FunSuiteLike with BeforeAndAf
}
}
+ def buildOnlyBinary(rows: Int, sortColumns: Array[String], path : String):
Any = {
Review comment:
existing binary testcase only can you add filter query ? I guess no need
to add new testcase for it, it will slow down CI running time.
##########
File path:
integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java
##########
@@ -78,6 +78,8 @@ private static DataType
spi2CarbondataTypeMapper(HiveColumnHandle columnHandle)
HiveType colType = columnHandle.getHiveType();
if (colType.equals(HiveType.HIVE_BOOLEAN)) {
return DataTypes.BOOLEAN;
+ } else if (colType.equals(HiveType.HIVE_BINARY)) {
Review comment:
I can see byte and float data type is also missing. can you add and test
for it ?
##########
File path:
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala
##########
@@ -230,6 +230,37 @@ class PrestoTestNonTransactionalTableFiles extends
FunSuiteLike with BeforeAndAf
}
}
+ def buildOnlyBinary(rows: Int, sortColumns: Array[String], path : String):
Any = {
Review comment:
existing binary testcase only can you add filter query ? I guess no need
to add new testcase for it, it will slow down CI running time.
##########
File path:
integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java
##########
@@ -78,6 +78,8 @@ private static DataType
spi2CarbondataTypeMapper(HiveColumnHandle columnHandle)
HiveType colType = columnHandle.getHiveType();
if (colType.equals(HiveType.HIVE_BOOLEAN)) {
return DataTypes.BOOLEAN;
+ } else if (colType.equals(HiveType.HIVE_BINARY)) {
Review comment:
I can see byte and float data type is also missing. can you add and test
for it ?
##########
File path:
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala
##########
@@ -230,6 +230,37 @@ class PrestoTestNonTransactionalTableFiles extends
FunSuiteLike with BeforeAndAf
}
}
+ def buildOnlyBinary(rows: Int, sortColumns: Array[String], path : String):
Any = {
Review comment:
existing binary testcase only can you add filter query ? I guess no need
to add new testcase for it, it will slow down CI running time.
##########
File path:
integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java
##########
@@ -78,6 +78,8 @@ private static DataType
spi2CarbondataTypeMapper(HiveColumnHandle columnHandle)
HiveType colType = columnHandle.getHiveType();
if (colType.equals(HiveType.HIVE_BOOLEAN)) {
return DataTypes.BOOLEAN;
+ } else if (colType.equals(HiveType.HIVE_BINARY)) {
Review comment:
I can see byte and float data type is also missing. can you add and test
for it ?
##########
File path:
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala
##########
@@ -230,6 +230,37 @@ class PrestoTestNonTransactionalTableFiles extends
FunSuiteLike with BeforeAndAf
}
}
+ def buildOnlyBinary(rows: Int, sortColumns: Array[String], path : String):
Any = {
Review comment:
existing binary testcase only can you add filter query ? I guess no need
to add new testcase for it, it will slow down CI running time.
##########
File path:
integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java
##########
@@ -78,6 +78,8 @@ private static DataType
spi2CarbondataTypeMapper(HiveColumnHandle columnHandle)
HiveType colType = columnHandle.getHiveType();
if (colType.equals(HiveType.HIVE_BOOLEAN)) {
return DataTypes.BOOLEAN;
+ } else if (colType.equals(HiveType.HIVE_BINARY)) {
Review comment:
I can see byte and float data type is also missing. can you add and test
for it ?
##########
File path:
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala
##########
@@ -230,6 +230,37 @@ class PrestoTestNonTransactionalTableFiles extends
FunSuiteLike with BeforeAndAf
}
}
+ def buildOnlyBinary(rows: Int, sortColumns: Array[String], path : String):
Any = {
Review comment:
existing binary testcase only can you add filter query ? I guess no need
to add new testcase for it, it will slow down CI running time.
##########
File path:
integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java
##########
@@ -78,6 +78,8 @@ private static DataType
spi2CarbondataTypeMapper(HiveColumnHandle columnHandle)
HiveType colType = columnHandle.getHiveType();
if (colType.equals(HiveType.HIVE_BOOLEAN)) {
return DataTypes.BOOLEAN;
+ } else if (colType.equals(HiveType.HIVE_BINARY)) {
Review comment:
I can see byte and float data type is also missing. can you add and test
for it ?
##########
File path:
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala
##########
@@ -230,6 +230,37 @@ class PrestoTestNonTransactionalTableFiles extends
FunSuiteLike with BeforeAndAf
}
}
+ def buildOnlyBinary(rows: Int, sortColumns: Array[String], path : String):
Any = {
Review comment:
existing binary testcase only can you add filter query ? I guess no need
to add new testcase for it, it will slow down CI running time.
##########
File path:
integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java
##########
@@ -78,6 +78,8 @@ private static DataType
spi2CarbondataTypeMapper(HiveColumnHandle columnHandle)
HiveType colType = columnHandle.getHiveType();
if (colType.equals(HiveType.HIVE_BOOLEAN)) {
return DataTypes.BOOLEAN;
+ } else if (colType.equals(HiveType.HIVE_BINARY)) {
Review comment:
I can see byte and float data type is also missing. can you add and test
for it ?
##########
File path:
integration/presto/src/test/scala/org/apache/carbondata/presto/integrationtest/PrestoTestNonTransactionalTableFiles.scala
##########
@@ -230,6 +230,37 @@ class PrestoTestNonTransactionalTableFiles extends
FunSuiteLike with BeforeAndAf
}
}
+ def buildOnlyBinary(rows: Int, sortColumns: Array[String], path : String):
Any = {
Review comment:
existing binary testcase only can you add filter query ? I guess no need
to add new testcase for it, it will slow down CI running time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
