ajantha-bhat commented on a change in pull request #3920: URL: https://github.com/apache/carbondata/pull/3920#discussion_r489158120
########## File path: integration/presto/src/main/prestosql/org/apache/carbondata/presto/PrestoFilterUtil.java ########## @@ -78,16 +78,22 @@ private static DataType spi2CarbondataTypeMapper(HiveColumnHandle columnHandle) HiveType colType = columnHandle.getHiveType(); if (colType.equals(HiveType.HIVE_BOOLEAN)) { return DataTypes.BOOLEAN; + } else if (colType.equals(HiveType.HIVE_BINARY)) { + return DataTypes.BINARY; } else if (colType.equals(HiveType.HIVE_SHORT)) { return DataTypes.SHORT; } else if (colType.equals(HiveType.HIVE_INT)) { return DataTypes.INT; + } else if (colType.equals(HiveType.HIVE_FLOAT)) { Review comment: please handle the same file changes in prestodb also and compile prestodb profile once with latest changes ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org