ajantha-bhat commented on a change in pull request #3944:
URL: https://github.com/apache/carbondata/pull/3944#discussion_r492562276
##########
File path:
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java
##########
@@ -466,15 +466,15 @@ public IndexFilter getFilterPredicates(Configuration
configuration) {
* get data blocks of given segment
*/
protected List<CarbonInputSplit> getDataBlocksOfSegment(JobContext job,
CarbonTable carbonTable,
- IndexFilter expression, List<Segment> segmentIds,
+ IndexFilter expression, List<Segment> validSegments,
Review comment:
Actually when the main table was giving 0 rows. I was debugging this
flow. And this naming is wrong. segmentID should be string, here it is not the
segmentID but the complete Segment object. so renamed. Still you want to revert
it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
