kunal642 commented on a change in pull request #3944:
URL: https://github.com/apache/carbondata/pull/3944#discussion_r492632500



##########
File path: 
hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonInputFormat.java
##########
@@ -466,15 +466,15 @@ public IndexFilter getFilterPredicates(Configuration 
configuration) {
    * get data blocks of given segment
    */
   protected List<CarbonInputSplit> getDataBlocksOfSegment(JobContext job, 
CarbonTable carbonTable,
-      IndexFilter expression, List<Segment> segmentIds,
+      IndexFilter expression, List<Segment> validSegments,

Review comment:
       its fine.. ill merge
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to