[GitHub] [carbondata] akashrn5 commented on a change in pull request #3946: [CARBONDATA-4002] Fix removal of columns from table schema.

[GitBox]

akashrn5 commented on a change in pull request #3946:
URL: https://github.com/apache/carbondata/pull/3946#discussion_r493205093



##########
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##########
@@ -442,7 +442,11 @@ object AlterTableUtil {
         // update schema for long string columns
         updateSchemaForLongStringColumns(thriftTable, longStringColumns.get)
       } else if (propKeys.exists(_.equalsIgnoreCase("long_string_columns") && 
!set)) {
-        updateSchemaForLongStringColumns(thriftTable, "")
+        val varcharColumns = 
carbonTable.getTableInfo.getFactTable.getListOfColumns.asScala.toList

Review comment:
       here instead of looping all columns, just check whether the long string 
property present in `tblPropertiesMap`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org