Karan980 commented on a change in pull request #3946:
URL: https://github.com/apache/carbondata/pull/3946#discussion_r493224739



##########
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##########
@@ -442,7 +442,11 @@ object AlterTableUtil {
         // update schema for long string columns
         updateSchemaForLongStringColumns(thriftTable, longStringColumns.get)
       } else if (propKeys.exists(_.equalsIgnoreCase("long_string_columns") && 
!set)) {
-        updateSchemaForLongStringColumns(thriftTable, "")
+        val varcharColumns = 
carbonTable.getTableInfo.getFactTable.getListOfColumns.asScala.toList

Review comment:
       Done

##########
File path: 
integration/spark/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
##########
@@ -442,7 +442,11 @@ object AlterTableUtil {
         // update schema for long string columns
         updateSchemaForLongStringColumns(thriftTable, longStringColumns.get)
       } else if (propKeys.exists(_.equalsIgnoreCase("long_string_columns") && 
!set)) {
-        updateSchemaForLongStringColumns(thriftTable, "")
+        val varcharColumns = 
carbonTable.getTableInfo.getFactTable.getListOfColumns.asScala.toList

Review comment:
       Done




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to