Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495512523
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/view/timeseries/TestCreateMVWithTimeSeries.scala
##########
@@ -165,20 +180,32 @@ class TestCreateMVWithTimeSeries extends QueryTest with
BeforeAndAfterAll {
sql("drop materialized view if exists mv2")
}
- test("insert and create materialized view in progress") {
+ test("reate materialized view should fail when parent table is insert
overwrite in progress") {
Review comment:
done
##########
File path:
integration/spark/src/test/scala/org/apache/carbondata/spark/testsuite/iud/DeleteCarbonTableTestCase.scala
##########
@@ -343,6 +342,31 @@ class DeleteCarbonTableTestCase extends QueryTest with
BeforeAndAfterAll {
sql("drop table if exists test_dm_index")
}
+ // block delete operation from table which has index. see PR2483
+ // DummyIndexFactory is used to pass the check "if(carbonTable.canAllow())"
+ // in class CarbonProjectForUpdateCommand
+ test("delete should fail if the table has index") {
+
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
