Kejian-Li commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495521844
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
##########
@@ -82,8 +82,9 @@ case class CarbonDropTableCommand(
}
}
- if (SegmentStatusManager.isLoadInProgressInTable(carbonTable)) {
- throw new ConcurrentOperationException(carbonTable, "loading", "drop
table")
+ if (SegmentStatusManager.isInsertInProgress(carbonTable)) {
+ throw new ConcurrentOperationException(carbonTable,
+ "insert or insert overwrite", "drop table")
Review comment:
done
##########
File path:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/schema/CarbonAlterTableRenameCommand.scala
##########
@@ -96,8 +96,9 @@ private[sql] case class CarbonAlterTableRenameCommand(
.asInstanceOf[CarbonRelation].carbonTable
carbonTableLockFilePath = carbonTable.getTablePath
// if any load is in progress for table, do not allow rename table
- if (SegmentStatusManager.isLoadInProgressInTable(carbonTable)) {
- throw new ConcurrentOperationException(carbonTable, "loading", "alter
table rename")
+ if (SegmentStatusManager.isInsertInProgress(carbonTable)) {
+ throw new ConcurrentOperationException(carbonTable,
+ "insert or insert overwrite", "alter table rename")
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
