Zhangshunyu commented on a change in pull request #3947:
URL: https://github.com/apache/carbondata/pull/3947#discussion_r495537900
##########
File path:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
##########
@@ -874,9 +874,9 @@ private ValidAndInvalidSegmentsInfo(List<Segment>
listOfValidSegments,
}
/**
- * Return true if any load or insert overwrite is in progress for specified
table
+ * Return true if insert or insert overwrite is in progress for specified
table
*/
- public static Boolean isLoadInProgressInTable(CarbonTable carbonTable) {
+ public static boolean isInsertInProgress(CarbonTable carbonTable) {
Review comment:
if you change the method name from 'load' to 'insert', you should change
the return parameter name the same time.
-> return loadInProgress to return insertInProgress
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
