Pickupolddriver commented on a change in pull request #3935:
URL: https://github.com/apache/carbondata/pull/3935#discussion_r502735735
##########
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
##########
@@ -267,9 +266,8 @@ object CarbonDataRDDFactory {
throw new Exception("Exception in compaction " +
exception.getMessage)
}
} finally {
- executor.shutdownNow()
try {
- compactor.deletePartialLoadsInCompaction()
Review comment:
(a). My PR will dependent on #3934 , if it merged first we don't need to
worry about the same segment ID in compaction situations. So it the
deletePartialLoadsInCompaction could be deleted.
(b). In this PR's design, the stale files would not be deleted
automatically. Users need to call cleanFiles function to clean them besides PR
#3917 can handle the clean files function.
(c). More places of calling claenStaleFiles have been removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
