akashrn5 commented on a change in pull request #3935:
URL: https://github.com/apache/carbondata/pull/3935#discussion_r503037126
##########
File path:
integration/spark/src/main/scala/org/apache/carbondata/spark/rdd/CarbonDataRDDFactory.scala
##########
@@ -267,9 +266,8 @@ object CarbonDataRDDFactory {
throw new Exception("Exception in compaction " +
exception.getMessage)
}
} finally {
- executor.shutdownNow()
try {
- compactor.deletePartialLoadsInCompaction()
Review comment:
@Pickupolddriver We cannot remove the clean stale files in case of
IUD and wait for clean files command to clean them, we should immediately clean
the stale ones in the respective command itself, as there will be chances of
extra data or data inconsistency. @QiangCai we can avoid this may be once we
implement the writing the update data to new segment and writing only the
delete delta files to the updated segment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
