ShreelekhyaG commented on a change in pull request #3988:
URL: https://github.com/apache/carbondata/pull/3988#discussion_r534676835
##########
File path:
core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
##########
@@ -198,20 +208,17 @@ public boolean accept(CarbonFile file) {
folderDetails.setRelative(isRelative);
folderDetails.setPartitions(partitionNames);
folderDetails.setStatus(SegmentStatus.SUCCESS.getMessage());
- for (CarbonFile file : carbonFiles) {
- if (file.getName().endsWith(CarbonTablePath.MERGE_INDEX_FILE_EXT)) {
- folderDetails.setMergeFileName(file.getName());
- } else {
- folderDetails.getFiles().add(file.getName());
- }
- }
+ setIndexFileNamesToFolderDetails(folderDetails, carbonFiles);
segmentFile.addPath(location, folderDetails);
String path = null;
if (isMergeIndexFlow) {
// in case of merge index flow, tasks are launched per partition and
all the tasks
// will be written to the same tmp folder, in that case taskNo is
not unique.
// To generate a unique fileName UUID is used
path = writePath + "/" + CarbonUtil.generateUUID() +
CarbonTablePath.SEGMENT_EXT;
+ if (readFileFooterFromCarbonDataFile) {
+ path = writePath + "/" + timeStamp + CarbonTablePath.SEGMENT_EXT;
Review comment:
removed unnecessary code from this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
