vikramahuja1001 commented on a change in pull request #4035:
URL: https://github.com/apache/carbondata/pull/4035#discussion_r535054960
##########
File path:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
##########
@@ -1039,17 +1039,19 @@ private static void
writeLoadMetadata(AbsoluteTableIdentifier identifier,
}
}
- private static ReturnTuple isUpdateRequired(boolean isForceDeletion,
CarbonTable carbonTable,
- AbsoluteTableIdentifier absoluteTableIdentifier, LoadMetadataDetails[]
details) {
+ private static ReturnTuple isUpdateRequired(boolean cleanStaleInProgress,
boolean
Review comment:
1. Trash behaviour remains unchanged. Trash will be deleted
automatically when option force = true, it's already in the document, If force
= true is not given, then it will delete trash according to timestamp retention
property.
2. in_progress = true, should only delete in_progress segments. Expired
trash will be deleted anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
