ajantha-bhat commented on a change in pull request #4035:
URL: https://github.com/apache/carbondata/pull/4035#discussion_r535321147
##########
File path:
core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java
##########
@@ -90,13 +93,13 @@ public static void
physicalFactAndMeasureMetadataDeletion(CarbonTable carbonTabl
* Delete the invalid data physically from table.
* @param carbonTable table
* @param loadDetails Load details which need clean up
- * @param isForceDelete is Force delete requested by user
+ * @param force Force delete Compacted and MFD segments
Review comment:
force --> isForceDelete
Also it will force clean the trash. add that also in header description
##########
File path:
core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java
##########
@@ -68,19 +68,22 @@ private static String
getSegmentPath(AbsoluteTableIdentifier identifier,
public static void physicalFactAndMeasureMetadataDeletion(CarbonTable
carbonTable,
LoadMetadataDetails[] newAddedLoadHistoryList,
- boolean isForceDelete,
+ boolean isForceDeletion,
Review comment:
keep it same as previous `isForceDelete`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
