ajantha-bhat commented on a change in pull request #4035:
URL: https://github.com/apache/carbondata/pull/4035#discussion_r536052356
##########
File path: docs/clean-files.md
##########
@@ -24,6 +24,7 @@ Clean files command is used to remove the Compacted, Marked
For Delete ,In Progr
```
CLEAN FILES FOR TABLE TABLE_NAME
```
+The above clean files command will clean Marked For Delete and Compacted
segments depending on ```MAX_QUERY_EXECUTION_TIME``` (default 1 hr) and ```
carbon.trash.retention.days``` (default 7 days). It will also delete the
timestamp subdirectories from the trash folder after expiration day(default 7
day, can be configured)
Review comment:
```suggestion
The above clean files command will clean Marked For Delete and Compacted
segments depending on ```max.query.execution.time``` (default 1 hr) and ```
carbon.trash.retention.days``` (default 7 days). It will also delete the
timestamp subdirectories from the trash folder after expiration day(default 7
day, can be configured)
```
##########
File path:
integration/spark/src/test/scala/org/apache/spark/util/CarbonCommandSuite.scala
##########
@@ -117,7 +117,7 @@ class CarbonCommandSuite extends QueryTest with
BeforeAndAfterAll {
val table = "carbon_table3"
createAndLoadTestTable(table, "csv_table")
DeleteSegmentById.main(Array(s"${location}", table, "0"))
- CleanFiles.main(Array(s"${location}", table))
+ CleanFiles.main(Array(s"${location}", table, "false", "true", "true"))
Review comment:
How it is passing without setting force allow carbon property
##########
File path:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
##########
@@ -1039,17 +999,19 @@ private static void
writeLoadMetadata(AbsoluteTableIdentifier identifier,
}
}
- private static ReturnTuple isUpdateRequired(boolean isForceDeletion,
CarbonTable carbonTable,
- AbsoluteTableIdentifier absoluteTableIdentifier, LoadMetadataDetails[]
details) {
+ private static ReturnTuple isUpdateRequired(boolean isForceDeletion, boolean
Review comment:
please keep new argument in the end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
