vikramahuja1001 commented on a change in pull request #4035:
URL: https://github.com/apache/carbondata/pull/4035#discussion_r536082283
##########
File path:
integration/spark/src/test/scala/org/apache/spark/util/CarbonCommandSuite.scala
##########
@@ -117,7 +117,7 @@ class CarbonCommandSuite extends QueryTest with
BeforeAndAfterAll {
val table = "carbon_table3"
createAndLoadTestTable(table, "csv_table")
DeleteSegmentById.main(Array(s"${location}", table, "0"))
- CleanFiles.main(Array(s"${location}", table))
+ CleanFiles.main(Array(s"${location}", table, "false", "true", "true"))
Review comment:
added code to fail in the cleanFiles API also
##########
File path:
core/src/main/java/org/apache/carbondata/core/statusmanager/SegmentStatusManager.java
##########
@@ -1039,17 +999,19 @@ private static void
writeLoadMetadata(AbsoluteTableIdentifier identifier,
}
}
- private static ReturnTuple isUpdateRequired(boolean isForceDeletion,
CarbonTable carbonTable,
- AbsoluteTableIdentifier absoluteTableIdentifier, LoadMetadataDetails[]
details) {
+ private static ReturnTuple isUpdateRequired(boolean isForceDeletion, boolean
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
