ajantha-bhat commented on a change in pull request #4051:
URL: https://github.com/apache/carbondata/pull/4051#discussion_r544072761
##########
File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java
##########
@@ -157,11 +157,12 @@ public static void deleteExpiredDataFromTrash(String
tablePath) {
// Deleting the timestamp based subdirectories in the trashfolder by the
given timestamp.
try {
if (FileFactory.isFileExist(trashPath)) {
Review comment:
I think we should deprecate listfiles and fileExist and other API in
file factory that takes path, it has to take carbon file instead of path. This
way we can force user to think about reusing the carbonFile Object.
we can raise a JIRA and assign some new contributors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
