ajantha-bhat commented on a change in pull request #4051:
URL: https://github.com/apache/carbondata/pull/4051#discussion_r544073512



##########
File path: core/src/main/java/org/apache/carbondata/core/util/TrashUtil.java
##########
@@ -157,11 +157,12 @@ public static void deleteExpiredDataFromTrash(String 
tablePath) {
     // Deleting the timestamp based subdirectories in the trashfolder by the 
given timestamp.
     try {
       if (FileFactory.isFileExist(trashPath)) {

Review comment:
       currently Vikram can handle for his PR by accepting suggested changes by 
Indhu. But many places we are not resuing the CarbonFile object. that can be 
handled by my above point.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to