[
https://issues.apache.org/jira/browse/CARBONDATA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614000#comment-15614000
]
ASF GitHub Bot commented on CARBONDATA-37:
------------------------------------------
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/219#discussion_r85460088
--- Diff:
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/carbonTableSchema.scala
---
@@ -1244,6 +1260,25 @@ case class LoadTableUsingKettle(
Seq.empty
}
+ private def validateDateFormat(dateFormat: String, dateDimensionsName:
ArrayBuffer[String]):
+ Unit = {
+ if (dateFormat == "") {
+ throw new MalformedCarbonCommandException("Error: Option DateFormat
is set an empty string.")
+ } else {
+ var dateFormats: Array[String] = dateFormat.split(",")
+ for (singleDateFormat <- dateFormats) {
+ var dateFormatSplits: Array[String] = singleDateFormat.split(":",
2)
+ if (!dateDimensionsName.contains(dateFormatSplits(0))) {
--- End diff --
take care case-insensitive
> Support Date/Time format for Timestamp columns to be defined at column level
> ----------------------------------------------------------------------------
>
> Key: CARBONDATA-37
> URL: https://issues.apache.org/jira/browse/CARBONDATA-37
> Project: CarbonData
> Issue Type: Improvement
> Reporter: Vimal Das Kammath
> Assignee: Lionx
>
> Carbon support defining the Date/Time format. But the configuration for the
> same is present in carbon.properties and hence is global for all tables.
> This global configuration for timestamp format cannot support scenarios where
> different tables or different Timestamp columns in the same table.
> Suggest to provide option in the create table DDL itself to define the format
> for each Timestamp column. Also provide defaults so that users can create
> table with Timestamp columns without having to always define the Date/Time
> format.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
