[
https://issues.apache.org/jira/browse/CARBONDATA-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15614004#comment-15614004
]
ASF GitHub Bot commented on CARBONDATA-37:
------------------------------------------
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/219#discussion_r85460589
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/surrogatekeysgenerator/csvbased/CarbonCSVBasedSeqGenStep.java
---
@@ -343,7 +345,8 @@ public boolean processRow(StepMetaInterface smi,
StepDataInterface sdi) throws K
}
data.setGenerator(
-
KeyGeneratorFactory.getKeyGenerator(getUpdatedLens(meta.dimLens,
meta.dimPresent)));
+ KeyGeneratorFactory.getKeyGenerator(
+ getUpdatedLens(meta.dimLens, meta.dimPresent)));
--- End diff --
keep code style
> Support Date/Time format for Timestamp columns to be defined at column level
> ----------------------------------------------------------------------------
>
> Key: CARBONDATA-37
> URL: https://issues.apache.org/jira/browse/CARBONDATA-37
> Project: CarbonData
> Issue Type: Improvement
> Reporter: Vimal Das Kammath
> Assignee: Lionx
>
> Carbon support defining the Date/Time format. But the configuration for the
> same is present in carbon.properties and hence is global for all tables.
> This global configuration for timestamp format cannot support scenarios where
> different tables or different Timestamp columns in the same table.
> Suggest to provide option in the create table DDL itself to define the format
> for each Timestamp column. Also provide defaults so that users can create
> table with Timestamp columns without having to always define the Date/Time
> format.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
