Github user landreamer commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/450#discussion_r93832594
--- Diff:
core/src/main/java/org/apache/carbondata/core/carbon/datastore/chunk/reader/dimension/v2/CompressedDimensionChunkFileBasedReaderV2.java
---
@@ -145,63 +144,52 @@ public
CompressedDimensionChunkFileBasedReaderV2(final BlockletInfo blockletInfo
long currentDimensionOffset = dimensionChunksOffset.get(blockIndex);
data = fileReader.readByteArray(filePath, currentDimensionOffset,
(int) (dimensionChunksOffset.get(blockIndex + 1) -
currentDimensionOffset));
- dimensionChunk = new byte[dimensionChunksLength.get(blockIndex)];
- System.arraycopy(data, copySourcePoint, dimensionChunk, 0,
- dimensionChunksLength.get(blockIndex));
- dimensionColumnChunk = CarbonUtil.readDataChunk(dimensionChunk);
+ dimensionColumnChunk =
+ CarbonUtil.readDataChunk(data, 0,
dimensionChunksLength.get(blockIndex));
--- End diff --
How about to use copySourcePoint instead of "0" to keep aligned with the
code below?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
