Github user landreamer commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/450#discussion_r93832815
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastorage/store/compression/ValueCompressonHolder.java
---
@@ -78,13 +86,22 @@ public static void unCompress(DataType dataType,
UnCompressValue value, byte[] d
UnCompressValue compress();
- UnCompressValue uncompress(DataType dataType);
+ UnCompressValue uncompress(DataType dataType, byte[] compressData, int
offset, int length,
+ int decimal, Object maxValueObject);
+
+ void setUncomressValue(T data, int decimal, Object maxValueObject);
--- End diff --
Should the function name be "setUncompressValue"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
