Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/551#discussion_r96883829
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/keygenerator/directdictionary/DirectDictionaryKeyGeneratorFactory.java
 ---
    @@ -57,9 +57,16 @@ public static DirectDictionaryGenerator 
getDirectDictionaryGenerator(DataType da
       }
     
       public static DirectDictionaryGenerator 
getDirectDictionaryGenerator(DataType dataType) {
    -    return getDirectDictionaryGenerator(dataType,
    -        CarbonProperties.getInstance()
    -            .getProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT,
    -                CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT));
    +    String format= null;
    --- End diff --
    
    Please use switch case


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to