Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/551#discussion_r96885139
--- Diff:
core/src/main/java/org/apache/carbondata/core/scan/filter/FilterUtil.java ---
@@ -1078,9 +1078,17 @@ public static int
compareFilterKeyBasedOnDataType(String dictionaryVal, String m
.compare((Boolean.parseBoolean(dictionaryVal)),
(Boolean.parseBoolean(memberVal)));
case DATE:
case TIMESTAMP:
- SimpleDateFormat parser = new
SimpleDateFormat(CarbonProperties.getInstance()
- .getProperty(CarbonCommonConstants.CARBON_TIMESTAMP_FORMAT,
- CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT));
+ String format= null;
+ if(dataType==DataType.DATE) {
--- End diff --
instead of using if else, please use inside case and use break;
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
