Github user JihongMA commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/554#discussion_r96988394
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
@@ -143,17 +142,18 @@ private void intialize() {
private int[] convertToArray(List<Integer> list) {
--- End diff --
this is all depending on if we want to hold a primitive type array not not.
these type of boxing/unboxing for primitive array type is annoying
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
