Github user jackylk commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/554#discussion_r97029982
--- Diff:
core/src/main/java/org/apache/carbondata/core/keygenerator/columnar/impl/MultiDimKeyVarLengthEquiSplitGenerator.java
---
@@ -143,17 +142,18 @@ private void intialize() {
private int[] convertToArray(List<Integer> list) {
--- End diff --
Yes, but this is another issue, which can be fixed in another PR. What I
mean here is caller of `convertToArray` can use `collection.toArray` from
java.util instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
