zwangsheng commented on code in PR #1804:
URL:
https://github.com/apache/incubator-celeborn/pull/1804#discussion_r1292934146
##########
charts/celeborn/templates/configmap.yaml:
##########
@@ -18,7 +18,7 @@
apiVersion: v1
kind: ConfigMap
metadata:
- name: celeborn-conf
+ name: {{ .Values.celebornClusterPrefix }}-conf
Review Comment:
Related to [Helm.sh#Release](https://helm.sh/docs/glossary/#release)
described, `Release` suits our scene.
>Release
When a chart is installed, the Helm library creates a release to track that
installation.
A single chart may be installed many times into the same cluster, and create
many different releases. For example, one can install three PostgreSQL
databases by running helm install three times with a different release name.
Instead of adding a new var in `values.yml`, we can use the built-in `{
.Release.name }`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
