zhongqiangczq commented on code in PR #1804:
URL:
https://github.com/apache/incubator-celeborn/pull/1804#discussion_r1299515634
##########
charts/celeborn/templates/prometheus-podmonitor.yaml:
##########
@@ -40,12 +40,15 @@ spec:
- {{ .Release.Namespace }}
selector:
matchLabels:
+ app.kubernetes.io/name: {{ .Chart.Name }}
+ app.kubernetes.io/instance: {{ .Release.Name }}
+ app.kubernetes.io/version: {{ .Chart.AppVersion | quote }}
Review Comment:
while rolling updating, there are maybe two version(i.e. v1, v2) both
existing. If you add "app.kubernetes.io/version" as a matchLabel, then
app.kubernetes.io/version equals v2 and then v1's pods will not be monitered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
