[GitHub] [incubator-celeborn] waitinfuture commented on pull request #1829: [CELEBORN-905] Redraw the flowchart backpressure.svg after worker pause logic is reconstructed

[via GitHub]

waitinfuture commented on PR #1829:
URL: 
https://github.com/apache/incubator-celeborn/pull/1829#issuecomment-1690880166

   > > LGTM. BTW, I think default 0.5 for 
`celeborn.worker.directMemoryRatioToResume` is too small, shall we change to 
0.7?
   > 
   > +1 for setting default resume ratio to `0.7`, I tried set `0.65` on a 
production-scale cluster with good results. Sounds `0.7` is reasonable.
   
   @zwangsheng Nice, so maybe we can change the default value in this PR and 
the svg can be changed at the same time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org