zwangsheng commented on code in PR #1829: URL: https://github.com/apache/incubator-celeborn/pull/1829#discussion_r1303745736
########## docs/configuration/worker.md: ########## @@ -39,7 +39,7 @@ license: | | celeborn.worker.directMemoryRatioForReadBuffer | 0.1 | Max ratio of direct memory for read buffer | 0.2.0 | | celeborn.worker.directMemoryRatioToPauseReceive | 0.85 | If direct memory usage reaches this limit, the worker will stop to receive data from Celeborn shuffle clients. | 0.2.0 | | celeborn.worker.directMemoryRatioToPauseReplicate | 0.95 | If direct memory usage reaches this limit, the worker will stop to receive replication data from other workers. This value should be higher than celeborn.worker.directMemoryRatioToPauseReceive. | 0.2.0 | -| celeborn.worker.directMemoryRatioToResume | 0.5 | If direct memory usage is less than this limit, worker will resume. | 0.2.0 | +| celeborn.worker.directMemoryRatioToResume | 0.7 | If direct memory usage is less than this limit, worker will resume. | 0.2.0 | Review Comment: Nice catch! I will add this change to `Upgrading from 0.3 to 0.4` part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1829: [CELEBORN-905] Redraw the flowchart backpressure.svg after worker pause logic is reconstructed](/search?l=issues@celeborn.apache.org&q=subject:%22%5C%5BGitHub%5C%5D+%5C%5Bincubator%5C-celeborn%5C%5D+zwangsheng+commented+on+a+diff+in+pull+request+%231829%5C%3A+%5C%5BCELEBORN%5C-905%5C%5D+Redraw+the+flowchart+backpressure.svg+after+worker+pause+logic+is+reconstructed%22&o=newest){kind=link}
