pan3793 commented on code in PR #1831:
URL:
https://github.com/apache/incubator-celeborn/pull/1831#discussion_r1303808097
##########
project/CelebornBuild.scala:
##########
@@ -62,34 +62,46 @@ object Dependencies {
val protocVersion = "3.19.2"
val protoVersion = "3.19.2"
- val commonsCrypto = "org.apache.commons" % "commons-crypto" %
commonsCryptoVersion
+ val commonsCrypto = "org.apache.commons" % "commons-crypto" %
commonsCryptoVersion excludeAll(
+ ExclusionRule("net.java.dev.jna", "jna"))
val commonsIo = "commons-io" % "commons-io" % commonsIoVersion
val commonsLang3 = "org.apache.commons" % "commons-lang3" %
commonsLang3Version
val findbugsJsr305 = "com.google.code.findbugs" % "jsr305" % findbugsVersion
val guava = "com.google.guava" % "guava" % guavaVersion
- val hadoopClientApi = "org.apache.hadoop" % "hadoop-client-api" %
hadoopVersion
- val hadoopClientRuntime = "org.apache.hadoop" % "hadoop-client-runtime" %
hadoopVersion
- val ioDropwizardMetricsCore = "io.dropwizard.metrics" % "metrics-core" %
metricsVersion
- val ioDropwizardMetricsGraphite = "io.dropwizard.metrics" %
"metrics-graphite" % metricsVersion
- val ioDropwizardMetricsJvm = "io.dropwizard.metrics" % "metrics-jvm" %
metricsVersion
- val ioNetty = "io.netty" % "netty-all" % nettyVersion
+ val hadoopClientApi = "org.apache.hadoop" % "hadoop-client-api" %
hadoopVersion excludeAll(
+ ExclusionRule("org.slf4j", "slf4j-api"))
Review Comment:
Let's use `force()` way.
> 1. Forcing can create logical inconsistencies so it’s no longer
recommended.
We know what we are doing, IMO, rules-based dependency derivation is more
unpredictable.
> 2. this is an Ivy-only feature and cannot be included in a published
pom.xml.
It does not affect our use case, since we only publish client-shaded
modules, without transitive deps.
##########
project/CelebornBuild.scala:
##########
@@ -62,34 +62,46 @@ object Dependencies {
val protocVersion = "3.19.2"
val protoVersion = "3.19.2"
- val commonsCrypto = "org.apache.commons" % "commons-crypto" %
commonsCryptoVersion
+ val commonsCrypto = "org.apache.commons" % "commons-crypto" %
commonsCryptoVersion excludeAll(
+ ExclusionRule("net.java.dev.jna", "jna"))
val commonsIo = "commons-io" % "commons-io" % commonsIoVersion
val commonsLang3 = "org.apache.commons" % "commons-lang3" %
commonsLang3Version
val findbugsJsr305 = "com.google.code.findbugs" % "jsr305" % findbugsVersion
val guava = "com.google.guava" % "guava" % guavaVersion
- val hadoopClientApi = "org.apache.hadoop" % "hadoop-client-api" %
hadoopVersion
- val hadoopClientRuntime = "org.apache.hadoop" % "hadoop-client-runtime" %
hadoopVersion
- val ioDropwizardMetricsCore = "io.dropwizard.metrics" % "metrics-core" %
metricsVersion
- val ioDropwizardMetricsGraphite = "io.dropwizard.metrics" %
"metrics-graphite" % metricsVersion
- val ioDropwizardMetricsJvm = "io.dropwizard.metrics" % "metrics-jvm" %
metricsVersion
- val ioNetty = "io.netty" % "netty-all" % nettyVersion
+ val hadoopClientApi = "org.apache.hadoop" % "hadoop-client-api" %
hadoopVersion excludeAll(
+ ExclusionRule("org.slf4j", "slf4j-api"))
Review Comment:
Let's use `force()` way.
> 1. Forcing can create logical inconsistencies so it’s no longer
recommended.
We know what we are doing, IMO, rules-based dependency derivation is more
unpredictable.
> 2. this is an Ivy-only feature and cannot be included in a published
pom.xml.
It does not affect our use case, since we only publish client-shaded
modules, without transitive deps.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
