cfmcgrady commented on code in PR #1831:
URL:
https://github.com/apache/incubator-celeborn/pull/1831#discussion_r1303857650
##########
project/CelebornBuild.scala:
##########
@@ -62,34 +62,46 @@ object Dependencies {
val protocVersion = "3.19.2"
val protoVersion = "3.19.2"
- val commonsCrypto = "org.apache.commons" % "commons-crypto" %
commonsCryptoVersion
+ val commonsCrypto = "org.apache.commons" % "commons-crypto" %
commonsCryptoVersion excludeAll(
+ ExclusionRule("net.java.dev.jna", "jna"))
val commonsIo = "commons-io" % "commons-io" % commonsIoVersion
val commonsLang3 = "org.apache.commons" % "commons-lang3" %
commonsLang3Version
val findbugsJsr305 = "com.google.code.findbugs" % "jsr305" % findbugsVersion
val guava = "com.google.guava" % "guava" % guavaVersion
- val hadoopClientApi = "org.apache.hadoop" % "hadoop-client-api" %
hadoopVersion
- val hadoopClientRuntime = "org.apache.hadoop" % "hadoop-client-runtime" %
hadoopVersion
- val ioDropwizardMetricsCore = "io.dropwizard.metrics" % "metrics-core" %
metricsVersion
- val ioDropwizardMetricsGraphite = "io.dropwizard.metrics" %
"metrics-graphite" % metricsVersion
- val ioDropwizardMetricsJvm = "io.dropwizard.metrics" % "metrics-jvm" %
metricsVersion
- val ioNetty = "io.netty" % "netty-all" % nettyVersion
+ val hadoopClientApi = "org.apache.hadoop" % "hadoop-client-api" %
hadoopVersion excludeAll(
+ ExclusionRule("org.slf4j", "slf4j-api"))
Review Comment:
I've also come across an alternative method for setting up
`dependencyOverrides` described here: [Overriding a
Version](https://www.scala-sbt.org/1.x/docs/Library-Management.html#Overriding+a+version).
Moreover, during my search, I observed that prominent projects employing SBT
as their build tool – like
[akka](https://github.com/akka/akka/blob/d7b17e9dec52cd27cd17192dda58598d229e3985/project/Dependencies.scala#L96),
[play](https://github.com/playframework/playframework/blob/d07e378e88471a4ec3613ebc842d4581143b047b/project/Dependencies.scala#L285),
and
[delta](https://github.com/delta-io/delta/blob/23826a3b25f39cc1097d3b6174f009da496028b7/build.sbt#L434)
– commonly adopt the `excludeAll` approach to exclude transitive dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
