waitinfuture commented on code in PR #2000:
URL:
https://github.com/apache/incubator-celeborn/pull/2000#discussion_r1378346251
##########
client-spark/spark-2/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala:
##########
@@ -119,7 +119,7 @@ class CelebornShuffleReader[K, C](
}
metricsCallback.incReadTime(
Review Comment:
IMO we need to count `openStream` time into read time because it belongs to
the shuffle read phase
##########
client-spark/spark-3/src/main/scala/org/apache/spark/shuffle/celeborn/CelebornShuffleReader.scala:
##########
@@ -121,7 +121,7 @@ class CelebornShuffleReader[K, C](
}
metricsCallback.incReadTime(
Review Comment:
IMO we need to count `openStream` time into read time because it belongs to
the shuffle read phase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
