waitinfuture commented on code in PR #2000:
URL:
https://github.com/apache/incubator-celeborn/pull/2000#discussion_r1378380075
##########
client/src/main/java/org/apache/celeborn/client/read/CelebornInputStream.java:
##########
@@ -56,7 +56,8 @@ public static CelebornInputStream create(
int attemptNumber,
int startMapIndex,
int endMapIndex,
- ConcurrentHashMap<String, Long> fetchExcludedWorkers)
+ ConcurrentHashMap<String, Long> fetchExcludedWorkers,
+ MetricsCallback metricsCallback)
Review Comment:
I think it's better to make metricsCallback a constructor argument
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
